-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce global-context index and related operations #65
Conversation
src/main/java/org/opensearch/flowframework/exception/FlowFrameworkException.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/function/ThrowingSupplier.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/function/ThrowingSupplierWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/function/ThrowingSupplierWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndex.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ProcessNode.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/indices/GlobalContextHandlerTests.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
============================================
- Coverage 91.68% 84.09% -7.59%
- Complexity 167 197 +30
============================================
Files 13 18 +5
Lines 565 742 +177
Branches 78 90 +12
============================================
+ Hits 518 624 +106
- Misses 24 88 +64
- Partials 23 30 +7
|
src/main/java/org/opensearch/flowframework/indices/GlobalContextHandler.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/exception/FlowFrameworkException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/GlobalContextHandler.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndexStepTests.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/exception/FlowFrameworkException.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/exception/FlowFrameworkException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/indices/GlobalContextHandlerTests.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndexStepTests.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndexStepTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks with few comments
src/main/java/org/opensearch/flowframework/indices/GlobalContextHandler.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/GlobalContextHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ProcessNode.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/indices/GlobalContextHandlerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndexStepTests.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/indices/GlobalContextHandler.java
Show resolved
Hide resolved
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing all the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jackiehanyang for addressing all the comments
* Add global context index and indices handler Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Update global context index mapping Signed-off-by: Jackie Han <jkhanjob@gmail.com> * correct checkstyle errors Signed-off-by: Jackie Han <jkhanjob@gmail.com> * skip index handler integ tests Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove indices integration tests for now Signed-off-by: Jackie Han <jkhanjob@gmail.com> * rebase - add global-context index handler Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Add unit tests Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove duplicate index name file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * refactor package and file names Signed-off-by: Jackie Han <jkhanjob@gmail.com> * spotless apply Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add javax ws dependency Signed-off-by: Jackie Han <jkhanjob@gmail.com> * remove visible for testing Signed-off-by: Jackie Han <jkhanjob@gmail.com> * add final keyword to map in Template ToXContect parser Signed-off-by: Jackie Han <jkhanjob@gmail.com> * spotless apply Signed-off-by: Jackie Han <jkhanjob@gmail.com> * disable checkStyleTest Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Add more unit tests Signed-off-by: Jackie Han <jkhanjob@gmail.com> * use OpenSearch rest status code Signed-off-by: Jackie Han <jkhanjob@gmail.com> * Addressing comments Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update resposnes field name to userOutputs Signed-off-by: Jackie Han <jkhanjob@gmail.com> * spotlessApply Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit c4f1fc7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…76) Introduce global-context index and related operations (#65) * Add global context index and indices handler * Update global context index mapping * correct checkstyle errors * skip index handler integ tests * remove indices integration tests for now * rebase - add global-context index handler * Add unit tests * remove duplicate index name file * refactor package and file names * spotless apply * add javax ws dependency * remove visible for testing * add final keyword to map in Template ToXContect parser * spotless apply * disable checkStyleTest * Add more unit tests * use OpenSearch rest status code * Addressing comments * update resposnes field name to userOutputs * spotlessApply --------- (cherry picked from commit c4f1fc7) Signed-off-by: Jackie Han <jkhanjob@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
responses
andresources_created
fieldsIssues Resolved
#51
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.